Fix UseKtx lint warnings in wear module
#5819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses UseKtx lint warnings in the wear module by replacing legacy Android APIs with their modern Kotlin extension (KTX) equivalents. The changes modernize the codebase by adopting more idiomatic Kotlin patterns.
Key changes made:
- Replaced manual styled attributes handling with KTX extension functions
- Updated URI parsing and bitmap scaling to use KTX alternatives
- Updated lint baselines to reflect the resolved warnings
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| LoadingView.kt | Replaced obtainStyledAttributes with withStyledAttributes KTX extension |
| CameraTile.kt | Replaced Bitmap.createScaledBitmap with Bitmap.scale KTX extension |
| PhoneInstallActivity.kt | Replaced Uri.parse with String.toUri KTX extension |
| ManualSetupPresenterImpl.kt | Replaced Uri.parse with String.toUri KTX extension |
| OnboardingPresenterImpl.kt | Replaced Uri.parse with String.toUri KTX extension |
| OnboardingActivity.kt | Replaced Uri.parse with String.toUri KTX extension |
| wear/lint-baseline.xml | Removed resolved UseKtx lint warnings |
| automotive/lint-baseline.xml | Updated line numbers for existing issues |
| app/lint-baseline.xml | Updated line numbers for existing issues |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixing all of the
UseKtxlint warnings in thewearmodule and updating the lint baseline accordingly, as part of #5221.Checklist