Replacing runBlocking with sensorWorkerScope in LocationSensorManager #5699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So why did you use |
I though it was tight to a lifecycle but in the end it isn't so I'm going to use IO 👍🏻. I don't think it has a huge impact since the underlying calls are made on another coroutine already on the DAO. |
jpelgrom
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of the effort describe in #5688 we should remove all the
runBlocking. The one in the LocationSensorManager are causing significant of ANRs within the app. The changes are quite straightforward I tested the changes on Android 16. I didn't see any regression there.Checklist