+
Skip to content

Use http instead of ftp to download TGGATES slide #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

alessiamarcolini
Copy link
Collaborator

@alessiamarcolini alessiamarcolini commented Nov 19, 2021

Description

Using HTTP instead of FTP to download from the TGGATES server takes 11 min (instead of 30min / 36min) at 560 KB/s (instead of 419 KB/s / 289 KB/s)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@alessiamarcolini alessiamarcolini marked this pull request as ready for review November 19, 2021 14:04
@alessiamarcolini alessiamarcolini changed the title Try to use http instead of ftp to download TGGATES slide Use http instead of ftp to download TGGATES slide Nov 19, 2021
@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #352 (c72df5d) into master (7f455d3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #352   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1408      1408           
  Branches       152       152           
=========================================
  Hits          1408      1408           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f455d3...c72df5d. Read the comment docs.

@alessiamarcolini alessiamarcolini added this to the 0.5.0 milestone Nov 19, 2021
Copy link
Member

@ernestoarbitrio ernestoarbitrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to have increased the performance for the artifact retrieval in the CI 👍🏽

@ernestoarbitrio ernestoarbitrio merged commit 641f2ac into master Nov 19, 2021
@alessiamarcolini alessiamarcolini modified the milestones: 0.5.0, 0.4.1 Nov 23, 2021
@alessiamarcolini alessiamarcolini deleted the tcgates-ci branch November 23, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wsi-artifacts job in CI taking too long
2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载