Fix expectations after upgrade to skimage 0.18.3 #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73110ae to
514610d
Compare
514610d to
83a51b6
Compare
ernestoarbitrio
approved these changes
Oct 11, 2021
83a51b6 to
99b75b0
Compare
|
Oh, skimage 0.18.3 deprecates Python 3.6, and given this library upgrade we also have to deprecate it (#222) |
99b75b0 to
5484d5d
Compare
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 1307 1310 +3
Branches 127 128 +1
=========================================
+ Hits 1307 1310 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains most of the fixes of the things which broke after upgrading to skimage 0.18.3.
To be merged after #200 and #328
To address all the issues we would need issue #197 to be fixed (PR #328)
🚨🚨 the expectations related to
rgb_to_hed,hematoxylin_channel,eosin_channel,dab_channel,NucleiScorer(dependent onhematoxylin_channel),CellularityScorer(dependent onhematoxylin_channel) andScoreTiler.locate_tiles(dependent onNucleiScorer) DO NOT MAKE SENSE RIGHT NOW. They will make sense in next PRs when we address substantial bugs that were in the codebase even before updating skimage 🚨🚨Types of Changes
Issues Fixed or Closed by This PR
Checklist