Add security linter with Bandit in pre commit and CI #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #316 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 1284 1284
Branches 124 124
=========================================
Hits 1284 1284 Continue to review full report at Codecov.
|
alessiamarcolini
requested changes
Aug 30, 2021
There was a problem hiding this comment.
Thanks for this contribution!!
Some comments:
- I would add a badge to our readme (see here https://github.com/PyCQA/bandit#show-your-style)
- I saw it's possible to use the file
pyproject.tomlto configure bandit and I would prefer to have the least number of configuration files - Bandit should also be included in
requirements-dev.txt
sure i forgot this :)
From docs seems feasible but actually won't work with the pyproject 🤷🏽
right |
alessiamarcolini
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add bandit hook in pre commit and CI (for reference https://github.com/PyCQA/bandit)
Types of Changes
Issues Fixed or Closed by This PR
Checklist