+
Skip to content

Locate tiles on slide's thumbnail #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Nov 27, 2020
Merged

Locate tiles on slide's thumbnail #179

merged 18 commits into from
Nov 27, 2020

Conversation

ernestoarbitrio
Copy link
Member

This PR contains:

  • Annotate slide thumbnail with tiles location. This is a diagnosis method to check where the tiles are (or will be) extracted from the slide.
    image

  • Remove UserWarning from pytest console and wrap it with pytest context managers

  • Various fix

@coveralls
Copy link

coveralls commented Nov 25, 2020 •
edited
Loading

Coverage Status

Coverage increased (+2.08%) to 100.0% when pulling 8a50d0c on locate-tiles-on-slides into 139dbb3 on master.

nicolebussola
nicolebussola reviewed Nov 25, 2020
View reviewed changes
nicolebussola
nicolebussola reviewed Nov 25, 2020
View reviewed changes
nicolebussola
nicolebussola reviewed Nov 25, 2020
View reviewed changes
nicolebussola
nicolebussola requested changes Nov 25, 2020
View reviewed changes
Copy link
Collaborator

@nicolebussola nicolebussola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor comments

@ernestoarbitrio ernestoarbitrio added 0.1.2 enhancement New feature or request labels Nov 25, 2020
@ernestoarbitrio
Copy link
Member Author

@nicolebussola @alessiamarcolini maybe you both can find a better name than locate_tiles ... I don't know maybe ... tile_outlines or something else sounds more better in your mind and in this specific topic.

@ernestoarbitrio ernestoarbitrio self-assigned this Nov 25, 2020
alessiamarcolini
alessiamarcolini requested changes Nov 25, 2020
View reviewed changes
Copy link
Collaborator

@alessiamarcolini alessiamarcolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

One thing that I would like to have is the possibility to customize the size of the image returned by locate_tiles, let's say we want to include the figure in a scientific paper or in a slide deck, the thumbnail may be too small. So the easiest option would be to accept the scale factor as a parameter and then use the scaled image instead of the thumbnail

@ernestoarbitrio
change rescaled operation and changing expectation because the old on…
27ce278 
…e returned not in coordinates that, actually, were wrong 'for the decimal place'
@ernestoarbitrio ernestoarbitrio linked an issue Nov 26, 2020 that may be closed by this pull request
reach 100% coverage on tiler module #161
Closed
@ernestoarbitrio
Copy link
Member Author

Looks good!

One thing that I would like to have is the possibility to customize the size of the image returned by locate_tiles, let's say we want to include the figure in a scientific paper or in a slide deck, the thumbnail may be too small. So the easiest option would be to accept the scale factor as a parameter and then use the scaled image instead of the thumbnail

this will be done in here : #181

alessiamarcolini
alessiamarcolini approved these changes Nov 26, 2020
View reviewed changes
Copy link
Collaborator

@alessiamarcolini alessiamarcolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alessiamarcolini
alessiamarcolini reviewed Nov 26, 2020
View reviewed changes
nicolebussola
nicolebussola approved these changes Nov 27, 2020
View reviewed changes
Copy link
Collaborator

@nicolebussola nicolebussola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ernestoarbitrio ernestoarbitrio merged commit 9f8e1d9 into master Nov 27, 2020
@ernestoarbitrio ernestoarbitrio deleted the locate-tiles-on-slides branch November 27, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessiamarcolini alessiamarcolini alessiamarcolini approved these changes

@nicolebussola nicolebussola nicolebussola approved these changes

Assignees

@ernestoarbitrio ernestoarbitrio

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reach 100% coverage on tiler module
4 participants
@ernestoarbitrio @coveralls @alessiamarcolini @nicolebussola
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载