Improve Stream Handling, Avoid Stream Reset on Recoverable Failures #4900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…move with cooldown, dynamic stream cooldown duration calculation
mur-me
approved these changes
May 15, 2025
Frozen
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refines the sync protocol’s stream handling to improve stability and responsiveness. Read deadlines are now applied to prevent blocking, with internal config support for tuning. The stream exits loops immediately on
closeCsignal, and locks have been refactored for better concurrency.To avoid confusion with the standard library, the stream type is renamed to
sync_stream. Recoverable errors like timeouts or network hiccups no longer trigger cooldowns or full resets, while critical errors are still handled with proper recovery logic. These changes reduce unnecessary disruptions and improve sync reliability.