Fix P2P Host Gater Initialization, Add new Blocking Gater to P2P Host #4904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frozen
approved these changes
May 21, 2025
sunwavesun
approved these changes
May 22, 2025
mur-me
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a critical issue in the P2P host initialization caused by conflicts between multiple gater implementations. To resolve this, the default gater was merged into a new blocking gater, ensuring a single, consistent gating mechanism throughout the system.
The blocking connection gater was refactored for clarity, and the P2P host was updated to use it exclusively. This eliminates the risk of overlapping gater logic and simplifies the initialization process.
Related tests were also updated and extended with datastore creation support to ensure reliability and correctness under the new structure.