Add Stream Removal Reason #4894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mur-me
approved these changes
Apr 28, 2025
Frozen
approved these changes
May 5, 2025
GheisMohammadi
added a commit
that referenced
this pull request
Jun 4, 2025
* add reason for stream removals in p2p layer * add stream removals reason for sync downloader * add reason for stream removals in staged stream sync
GheisMohammadi
added a commit
that referenced
this pull request
Jun 4, 2025
* add reason for stream removals in p2p layer * add stream removals reason for sync downloader * add reason for stream removals in staged stream sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves logging and observability by adding reason strings whenever a stream is removed. It covers the P2P layer, the sync downloader, and staged stream sync. Each stream removal now clearly logs why it happened, such as invalid blocks, connectivity issues, or missing responses.
Previously, it was hard to trace the cause of stream closures, which made investigations slower. With this change, we can quickly identify issues in the logs and improve troubleshooting for sync and networking problems.