+
Skip to content

[bootnode] - sync the http and ws setup with cli IP variable #4886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

[bootnode] - sync the http and ws setup with cli IP variable #4886

merged 1 commit into from
Apr 23, 2025

Conversation

mur-me
Copy link
Collaborator

@mur-me mur-me commented Apr 16, 2025 •
edited
Loading

Issue

I've put the same ip from the cli setup, because previously bootnode was listening only localhost aka 127.0.0.1 by default.

Additionally, I've moved default port from 9500 to 9513 and 9800 to 9813, because when we have both harmony and bootnode on the same server - we are starting to play the game who is faster for takeover the port after server reboot.

Test

  • I've installed my updated version on the one of devnet bootnodes and what I have, as you can see it is listening on the 0.0.0.0 as original config from the cli:
sudo netstat -plnt | grep bootnode
tcp        0      0 0.0.0.0:9020            0.0.0.0:*               LISTEN      6636/bootnode       
tcp6       0      0 :::9813                 :::*                    LISTEN      6636/bootnode       
tcp6       0      0 :::9513                 :::*                    LISTEN      6636/bootnode
  • Additionally, I was able to run curl request to the bootnode's RPC when I'm under VPN - it gives us possibilities to enhance our internal monitoring/integration tests in the future:
curl -H 'Content-Type:application/json' -X POST 'bootnodes_host:9513' -d '{"id":"1","jsonrpc":"2.0","method":"hmybootv2_getNodeMetadata","params":[]}' | jq
---
{
  "jsonrpc": "2.0",
  "id": "1",
  "result": {
    "network": "mainnet",
    "node-unix-start-time": 1744884005,
    "p2p-connectivity": {
      "connected": 2433,
      "not-connected": 5436,
      "total-known-peers": 7869
    },
    "peerid": "QmRdKvrGyWVxwXTcu4YiC5bPMLPqFSmneDG1jwuUnQcn2W",
    "version": "Harmony (C) 2025. bootnode, version v8688-v2025.4.0-15-g0b4aed9dd (uladzislau@ 2025-04-16T16:52:09+0300)"
  }
}

@mur-me mur-me force-pushed the chore_bootnode_sync_http_setup_with_cli_setup branch 2 times, most recently from 0b4aed9 to 4edd4a4 Compare April 16, 2025 14:18
@mur-me
Copy link
Collaborator Author

mur-me commented Apr 16, 2025

Travis CI for some reason don't like my commit + Gheis fix together, let's retry after merge of #4885

@mur-me mur-me changed the title Chore bootnode sync http setup with cli setup Chore bootnode sync the http and ws setup with cli variables Apr 16, 2025
@mur-me mur-me force-pushed the chore_bootnode_sync_http_setup_with_cli_setup branch from 4edd4a4 to b32164a Compare April 17, 2025 10:31
@mur-me mur-me changed the title Chore bootnode sync the http and ws setup with cli variables [bootnode] - sync the http and ws setup with cli IP variable Apr 17, 2025
@mur-me mur-me marked this pull request as ready for review April 17, 2025 10:42
@mur-me mur-me merged commit dd0dc92 into dev Apr 23, 2025
3 checks passed
@mur-me mur-me deleted the chore_bootnode_sync_http_setup_with_cli_setup branch April 23, 2025 08:55
@mur-me mur-me mentioned this pull request May 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GheisMohammadi GheisMohammadi GheisMohammadi approved these changes

@Frozen Frozen Awaiting requested review from Frozen

+1 more reviewer

@sunwavesun sunwavesun sunwavesun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mur-me @GheisMohammadi @sunwavesun
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载