+
Skip to content

allow to load ignore list from file #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dontcallmedom
Copy link
Contributor

No description provided.

@@ -896,7 +925,7 @@ sub parse_arguments ()
}
}
for my $sf_arg (@{$Opts{Suppress_Fragment}}) {
if ($sf_arg !~ /.#./) {
if ($sf_arg !~ /#./) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change isn't related to the current pull request - which is fine with me. But I am curious about what problem you were solving with this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually is related; I want to allow to specify "#foo" as valid fragment check to suppress (since when you do that from a file, you don't want to hardcode the path of the file you're checking).

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh - nice feature. I see how it works. Maybe we should document that if a line in the file is only a fragment it is appended to the base URI being checked?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that'd make sense; can you suggest something that would fit in a command line help?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that you may specify a fragment with no scheme or path (e.g., #myfragment). In this case the fragment will be considered internal to the URI being checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载