+
Skip to content

perf(getRequestIP): improve performances #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 29, 2025
Merged

perf(getRequestIP): improve performances #1197

merged 2 commits into from
Sep 29, 2025

Conversation

homersimpsons
Copy link
Contributor

@homersimpsons homersimpsons commented Aug 29, 2025 •
edited
Loading

Previous implementations shortcommings:

(_header || "")?.split(",").shift()?.trim();
         |     |           |       \- Useless as we have a string before `split`, so at least 1 string element in the array
         |     |           \- Useless as we can just get the first character `[0]`
         |     \- Useless as we cannot have undefined before
         \- Useless as we can just skip the whole computation if the header is falsy
  • Remove header fallback to empty string
  • Remove useless undefined check
  • Uses [0] instead of shifting

Note that I also tried to play with substring / slice and use split(',', 2) but that didn't seem to improve the performances.

Resolves #1196

perf.link reports that the new implementation is twice faster on a micro-benchmark

@homersimpsons
⚡ Slightly improve getRequestIP performances
81bc7b3 
- Remove header fallback to empty string
- Remove useless undefined check
- Uses [0] instead of shifting
@homersimpsons homersimpsons requested a review from pi0 as a code owner August 29, 2025 16:07
@codecov Codecov
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

homersimpsons
homersimpsons commented Aug 29, 2025
View reviewed changes
@pi0 pi0 changed the title ⚡ Slightly improve getRequestIP performances perf(getRequestIP): improve performances Sep 29, 2025
pi0
pi0 reviewed Sep 29, 2025
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANKS!

@pi0 pi0 merged commit ede19bf into h3js:main Sep 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

getRequestIP implementation is suboptimal

2 participants

@homersimpsons @pi0
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载