+
Skip to content

feat!: app.request #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 30, 2025
Merged

feat!: app.request #1176

merged 5 commits into from
Jul 30, 2025

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jul 30, 2025 •
edited
Loading

Followup on #1096 with app.fetch(req) becoming more restricted, it makes sense we make app.request(req, init, ctx) a public API to unblock DX limits.

Other API change: Types are now Response | Promise<Response> to reduce unnecessary wrappings. (please comment if anyone feels this is a bad DX)

@pi0 pi0 mentioned this pull request Jul 30, 2025
Merged
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jul 30, 2025 •
edited
Loading

Deploying h3dev with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1344e7d
Status: ✅  Deploy successful!
Preview URL: https://117d2cd8.h3dev.pages.dev
Branch Preview URL: https://feat-app-req.h3dev.pages.dev

View logs

@codecov Codecov
Copy link

codecov bot commented Jul 30, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/_entries/bun.ts 0.00% 1 Missing ⚠️
src/_entries/cloudflare.ts 0.00% 1 Missing ⚠️
src/_entries/deno.ts 0.00% 1 Missing ⚠️
src/_entries/generic.ts 0.00% 1 Missing ⚠️
src/_entries/node.ts 0.00% 1 Missing ⚠️
src/_entries/service-worker.ts 0.00% 1 Missing ⚠️
src/adapters.ts 0.00% 1 Missing ⚠️
src/utils/proxy.ts 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@pi0 pi0 merged commit 96a9453 into main Jul 30, 2025
3 checks passed
@pi0 pi0 deleted the feat/app-req branch July 30, 2025 12:26
@huseeiin
Copy link
Contributor

huseeiin commented Aug 1, 2025

yes i think it should be Promise<Response> to match globalThis.fetch. imagine someone making an SSR framework and they override globalThis.fetch so it works like SPA (similar to nuxt useFetch, P.S. i know useFetch is not overriding globalThis.fetch). users then will use fetch("/route").then(res => res.json()) and get fetch("/route").then is undefined error

@pi0
Copy link
Member Author

pi0 commented Aug 1, 2025

Wrappers can easily use Promise.resolve() when overriding globalThis.fetch to match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pi0 @huseeiin
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载