+
Skip to content

feat(middleware): allow passthrough response without enforcing explicit return #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 30, 2025
Merged

feat(middleware): allow passthrough response without enforcing explicit return #1174

merged 3 commits into from
Jul 30, 2025

Conversation

kricsleo
Copy link
Member

resolves #1172

This PR enables middleware to pass through the response from other middlewares or handler without enforcing an explicit return next().

This improves DX, especially when the user doesn't care about the response and is likely to forget to return after calling next().

Before:

app.use(async (event, next) => {
  // before...
  const result = await next()
  // after...

  // ↓ this is likely to be forgotton.
  return result
})

After:

app.use(async (event, next) => {
  // before...
  await next()
  // after...

  // no needs to return
})

@kricsleo kricsleo requested a review from pi0 as a code owner July 27, 2025 10:52
@codecov Codecov
Copy link

codecov bot commented Jul 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

pi0
pi0 approved these changes Jul 30, 2025
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ❤️

@pi0 pi0 merged commit 2608148 into h3js:main Jul 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v2: Calling await next() in global middleware causes request handlers to be called twice

2 participants

@kricsleo @pi0
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载