-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: Add fork PR workflows permission API support #3737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3737 +/- ##
==========================================
+ Coverage 91.34% 91.38% +0.03%
==========================================
Files 187 187
Lines 16702 16764 +62
==========================================
+ Hits 15257 15319 +62
Misses 1257 1257
Partials 188 188 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes: #3660. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @zyfy29 - thank you!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I may have missed this from the other PRs but I don't feel like the In<CONTEXT>
suffix feels ergonomic. The context is significant to the API call (it's the first segment) so making it the least significant part of the function name just looks a bit off.
@zyfy29 - please fix the linter and test failures and push the changes to this PR. |
Now it should be OK |
Thank you, @alexandear! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you, @stevehipwell! |
Fixes: #3660.
close #3660 since this is the last part of the permissions APIs announced there
Add support for fork PR workflow permission APIs, covering 6 endpoints.