+
Skip to content

Conversation

zyfy29
Copy link
Contributor

@zyfy29 zyfy29 commented Sep 26, 2025

Fixes: #3660.

close #3660 since this is the last part of the permissions APIs announced there

Add support for fork PR workflow permission APIs, covering 6 endpoints.

Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.38%. Comparing base (22f34ec) to head (1835972).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3737      +/-   ##
==========================================
+ Coverage   91.34%   91.38%   +0.03%     
==========================================
  Files         187      187              
  Lines       16702    16764      +62     
==========================================
+ Hits        15257    15319      +62     
  Misses       1257     1257              
  Partials      188      188              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 26, 2025

Fixes: #3660.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Sep 26, 2025
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @zyfy29 - thank you!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear

@zyfy29 zyfy29 requested a review from alexandear October 3, 2025 07:10
Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I may have missed this from the other PRs but I don't feel like the In<CONTEXT> suffix feels ergonomic. The context is significant to the API call (it's the first segment) so making it the least significant part of the function name just looks a bit off.

@zyfy29 zyfy29 requested a review from stevehipwell October 7, 2025 07:20
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Oct 7, 2025
@gmlewis
Copy link
Collaborator

gmlewis commented Oct 7, 2025

@zyfy29 - please fix the linter and test failures and push the changes to this PR.

@zyfy29
Copy link
Contributor Author

zyfy29 commented Oct 7, 2025

Now it should be OK

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 7, 2025

Thank you, @alexandear!
@stevehipwell - are you happy with the changes (since you requested them)?

Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 8, 2025

Thank you, @stevehipwell!
Merging.

@gmlewis gmlewis merged commit 8fd1cb9 into google:master Oct 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for new actions APIs

4 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载