+
Skip to content

Conversation

zyfy29
Copy link
Contributor

@zyfy29 zyfy29 commented Aug 12, 2025

a fix for #3662 (cc #3660)

There are 6 apis' paths begin with organizations instead of orgs.

To verify that orgs is not a alias of organizations, accessing https://api.github.com/organizations/google/actions/permissions/self-hosted-runners with no permissions gives a 404 error while https://api.github.com/orgs/google/actions/permissions/self-hosted-runners gives a 403 error.

@Copilot Copilot AI review requested due to automatic review settings August 12, 2025 06:01
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes incorrect API path patterns in the OpenAPI operations configuration by changing 6 endpoint paths from using /organizations/ to /orgs/ to align with GitHub's actual API structure. The change ensures the API paths correctly reference GitHub's organization endpoints.

  • Updates 6 API endpoints for self-hosted runners permissions from /organizations/{org}/ to /orgs/{org}/
  • Maintains consistency with GitHub's API URL patterns where organization endpoints use /orgs/ rather than /organizations/

@gmlewis
Copy link
Collaborator

gmlewis commented Aug 12, 2025

So I'm a bit concerned and confused by this PR.

First, how were these changes generated? The openapi_operations.yaml file is auto-generated and should not be edited.
This is because the next time it is updated, it will be completely overwritten.

Second, if there are errors in openapi_operations.yaml, then GitHub tech support needs to be notified and they need to fix the changes on their side.

Third, openapi_operations.yaml is typically only updated by the maintainers of this repo when new APIs need to be supported.

@zyfy29
Copy link
Contributor Author

zyfy29 commented Aug 12, 2025

I didn't follow the rules, sorry.

But I did find that something strange happened. It seems that github replace some newly added api endpoint path organizations with orgs so I got some lint error. Now I will fork master and open a new pr to do that. Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载