feat: Add self-hosted runner permission API support #3675
Conversation
…ner-permission-api
There was a problem hiding this comment.
Pull Request Overview
This pull request adds comprehensive API support for GitHub self-hosted runner permissions management, implementing 8 new endpoints for organization and enterprise level configuration. The changes enable users to manage repository-level self-hosted runner permissions and control which repositories can use self-hosted runners.
- Adds organization-level endpoints for managing self-hosted runner permissions and repository access
- Introduces enterprise-level endpoints for controlling organization permissions
- Implements complete CRUD operations with proper data structures and validation
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| github/actions_permissions_orgs.go | Implements 6 organization-level API methods for managing self-hosted runner settings and repository permissions |
| github/actions_permissions_orgs_test.go | Provides comprehensive test coverage for all organization-level self-hosted runner API methods |
| github/actions_permissions_enterprise.go | Adds 2 enterprise-level API methods for getting and setting self-hosted runner permissions |
| github/actions_permissions_enterprise_test.go | Tests enterprise-level self-hosted runner permission methods |
| github/github-accessors.go | Generates accessor methods for the new struct fields |
| github/github-accessors_test.go | Tests the new accessor methods |
| github/github-stringify_test.go | Tests string representation methods for new structs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
f6143da to
287224e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3675 +/- ##
==========================================
+ Coverage 91.23% 91.28% +0.04%
==========================================
Files 185 185
Lines 16421 16511 +90
==========================================
+ Hits 14982 15072 +90
Misses 1254 1254
Partials 185 185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Thank you, @zyfy29!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
@alexandear or @stevehipwell - might either of you have time for a code review? Thank you!
|
Thank you, @stevehipwell! |
2nd Pull Request for #3660
Add support for the "Setting which repositories can create repository-level self-hosted runners" APIs, covering 8 endpoints.