Add case-instensitive GetHeader for HookRequest & HookResponse #3556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3556 +/- ##
=======================================
Coverage 91.23% 91.24%
=======================================
Files 183 183
Lines 16053 16063 +10
=======================================
+ Hits 14646 14656 +10
Misses 1231 1231
Partials 176 176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
requested changes
Apr 18, 2025
|
Oh you right! Completely forgot about negative cases) |
gmlewis
approved these changes
Apr 18, 2025
There was a problem hiding this comment.
Thank you, @sparshev!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
@stevehipwell - might you have time for a code review? Thank you!
|
LGTM! Tiny nit: wdyt to abstract the common functionality into a shared helper function aims to reduce code duplication like below? |
atilsensalduz
approved these changes
Apr 18, 2025
|
Thank you, @atilsensalduz and @sparshev! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple implementation for case-insensitive GetHeader. I thought about caching the keys, but it seems too complicated for now with additional not predictable memory consumption. Tests are included.
Fixes #3555