Add support for registry_package event #3545
Conversation
as of the time of this writing, the Github documentation describes two events related to packages. One called package and one called registry_package. According to the documentation, users should switch to using the package event instead of the registry_package event. However, when working with the actual permissions and events, there is no package event but there is a RegistryPackage event that can be enabled for a Github App. It looks like the documentation is wrong and the registry_package event was added after the package event and it's the registry_package event that users should expect to receive.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3545 +/- ##
==========================================
- Coverage 91.29% 91.23% -0.07%
==========================================
Files 184 183 -1
Lines 16169 16053 -116
==========================================
- Hits 14762 14646 -116
Misses 1231 1231
Partials 176 176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Thank you, @ptzianos!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
@stevehipwell - might you have time for a code review? Thank you!
|
@stevehipwell @gmlewis thank you both for the prompt reviews, do I need to fix the codecov check to get the change merged? |
No need, thank you. Thank you, @stevehipwell! Merging. |
as of the time of this writing, the Github documentation describes two events related to packages. One called package and one called registry_package. According to the documentation, users should switch to using the package event instead of the registry_package event. However, when working with the actual permissions and events, there is no package event but there is a RegistryPackage event that can be enabled for a Github App. It looks like the documentation is wrong and the registry_package event was added after the package event and it's the registry_package event that users should expect to receive.
Fixes: #3544.