+
Skip to content

chore!: Remove support for Required Workflows #3538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 7, 2025

Conversation

Abiji-2020
Copy link
Contributor

Fixes: #2907

Signed-off-by: Abinand P <abinand0911@gmail.com>
@gmlewis gmlewis changed the title Removal of support for the Required Workflows. chore!: Remove support for Required Workflows Apr 7, 2025
@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Apr 7, 2025
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.23%. Comparing base (3a3f51b) to head (be72d2d).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3538      +/-   ##
==========================================
- Coverage   91.29%   91.23%   -0.07%     
==========================================
  Files         184      183       -1     
  Lines       16169    16053     -116     
==========================================
- Hits        14762    14646     -116     
  Misses       1231     1231              
  Partials      176      176              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Abiji-2020!
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@stevehipwell - might you have time for a code review? Thank you!

Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Apr 7, 2025
@gmlewis
Copy link
Collaborator

gmlewis commented Apr 7, 2025

Thank you, @stevehipwell!
Merging.

@gmlewis gmlewis merged commit 7db22ac into google:master Apr 7, 2025
6 of 7 checks passed
@Abiji-2020 Abiji-2020 deleted the required-workflow-removal branch April 7, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Required workflows is being removed from the API
3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载