+
Skip to content

fix!: Typo in field names in the CheckSuite struct #3444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Jan 20, 2025

BREAKING CHANGE: Rerequstable=>Rerequestable, RunsRerequstable=>RunsRerequestable

Fixes: #3443.

@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Jan 20, 2025
@alexandear alexandear force-pushed the fix/typo-checksuite-fields branch from 5eb0ba3 to 0388ebe Compare January 20, 2025 17:59
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.26%. Comparing base (eb92cca) to head (0388ebe).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3444   +/-   ##
=======================================
  Coverage   92.26%   92.26%           
=======================================
  Files         174      174           
  Lines       15023    15023           
=======================================
  Hits        13861    13861           
  Misses       1068     1068           
  Partials       94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexandear
Copy link
Contributor Author

@gmlewis, maybe it makes sense to configure "Approval for running fork pull request workflows from contributors", so that workflows run automatically for all users who have contributed to the repo.

image

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 20, 2025

@gmlewis, maybe it makes sense to configure "Approval for running fork pull request workflows from contributors", so that workflows run automatically for all users who have contributed to the repo.

Yes, thank you, @alexandear, but unfortunately, as a Xoogler, I no longer have access to that link.
This is how I have set my other repos that I do control, but can no longer control the settings for this repo.
Also, unfortunately, I do not seem to get responses any more from the team that does. 😞

As a result, I attempt to be responsive when changes are made to PRs and check for malware before clicking "Approve".
Triple unfortunately, this last year I've seen the most attacks on this repo with malware than any of the other prior many years I've been maintaining this repo... so I must be careful with commits.

I understand that it is frustrating to push a commit and then watch and wait for the CI/CD tooling to run, and I apologize.
I will continue to try and be responsive and I greatly appreciate your patience. Thank you!

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear!
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@stevehipwell - do you have time for a code review?

Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 20, 2025

Thank you, @stevehipwell!
Merging.

@gmlewis gmlewis changed the title fix: Typo in field names in the CheckSuite struct fix!: Typo in field names in the CheckSuite struct Jan 20, 2025
@gmlewis gmlewis merged commit c44e9dd into google:master Jan 20, 2025
8 of 11 checks passed
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in field names in the CheckSuite struct
3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载