+
Skip to content

chore: Remove commented out test code #3381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2024
Merged

chore: Remove commented out test code #3381

merged 1 commit into from
Dec 11, 2024

Conversation

alexandear
Copy link
Contributor

The PR removes duplicated commented TestActionsService_ListSelectedReposForOrgSecret. This test is already present here:

go-github/github/actions_secrets_test.go

Lines 505 to 510 in f66ed85

func TestActionsService_ListSelectedReposForOrgSecret(t *testing.T) {
t.Parallel()
client, mux, _ := setup(t)
mux.HandleFunc("/orgs/o/actions/secrets/NAME/repositories", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "GET")

Note: In the future, better to mark a test with t.Skip instead of commenting.

@alexandear alexandear changed the title chore: remove commented out test code chore: Remove commented out test code Dec 11, 2024
stevehipwell
stevehipwell approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.27%. Comparing base (2b8c7fa) to head (9895b8b).
Report is 196 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3381      +/-   ##
==========================================
- Coverage   97.72%   92.27%   -5.45%     
==========================================
  Files         153      176      +23     
  Lines       13390    15033    +1643     
==========================================
+ Hits        13085    13872     +787     
- Misses        215     1068     +853     
- Partials       90       93       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gmlewis
gmlewis approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear and @stevehipwell !
LGTM.
Merging.

@gmlewis gmlewis merged commit c7f49d2 into google:master Dec 11, 2024
6 of 7 checks passed
@alexandear alexandear deleted the chore/remove-commented-test branch December 11, 2024 14:06
@gmlewis gmlewis mentioned this pull request Dec 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewis gmlewis gmlewis approved these changes

+1 more reviewer

@stevehipwell stevehipwell stevehipwell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexandear @stevehipwell @gmlewis
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载