fix: Avoid allocation in the stringifyValue #3292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmlewis
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Thank you, @alexandear !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3292 +/- ##
==========================================
- Coverage 97.72% 92.97% -4.75%
==========================================
Files 153 171 +18
Lines 13390 11715 -1675
==========================================
- Hits 13085 10892 -2193
- Misses 215 729 +514
- Partials 90 94 +4 ☔ View full report in Codecov by Sentry. |
|
Thank you, @air-hand ! |
gmlewis
pushed a commit
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR refactors implementation of the
stringifyValuefunction.w.Write([]byte("<nil>"))may allocate, better is to usew.WriteString("<nil>")