+
Skip to content

Conversation

felixlut
Copy link
Contributor

Resolves #3282

It was only possible to list organization roles before, this makes it possible to get a specific one.

I might have went overboard with the test-cases (testing both a custom role and a built-in one). I haven't written mocks before, so I'm not sure what the best practices are here 😅

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.95%. Comparing base (2b8c7fa) to head (68caaad).
Report is 119 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3285      +/-   ##
==========================================
- Coverage   97.72%   92.95%   -4.77%     
==========================================
  Files         153      171      +18     
  Lines       13390    11679    -1711     
==========================================
- Hits        13085    10856    -2229     
- Misses        215      729     +514     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Sep 22, 2024
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @felixlut !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

Copy link
Contributor

@tomfeigin tomfeigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 23, 2024

Thank you, @tomfeigin !
Merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Sep 23, 2024
@gmlewis gmlewis merged commit c0f5841 into google:master Sep 23, 2024
6 of 7 checks passed
@felixlut felixlut deleted the get-org-role branch September 23, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Support getting an organization role

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载