+
Skip to content

feat: Add do_not_enforce_on_create to required status checks rule params #3245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2024
Merged

feat: Add do_not_enforce_on_create to required status checks rule params #3245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf8dda0
feat: add do_not_enforce_on_create to required status checks rule params
MattMencel Aug 22, 2024
5c88e6f
chore: fix test
MattMencel Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions github/repos_rules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ type RuleRequiredStatusChecks struct {

// RequiredStatusChecksRuleParameters represents the required_status_checks rule parameters.
type RequiredStatusChecksRuleParameters struct {
DoNotEnforceOnCreate bool `json:"do_not_enforce_on_create"`
RequiredStatusChecks []RuleRequiredStatusChecks `json:"required_status_checks"`
StrictRequiredStatusChecksPolicy bool `json:"strict_required_status_checks_policy"`
}
Expand Down
3 changes: 2 additions & 1 deletion github/repos_rules_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,9 @@ func TestRepositoryRule_UnmarshalJSON(t *testing.T) {
wantErr: true,
},
"Valid required_status_checks params": {
data: `{"type":"required_status_checks","parameters":{"required_status_checks":[{"context":"test","integration_id":1}],"strict_required_status_checks_policy":true}}`,
data: `{"type":"required_status_checks","parameters":{"required_status_checks":[{"context":"test","integration_id":1}],"strict_required_status_checks_policy":true,"do_not_enforce_on_create":true}}`,
want: NewRequiredStatusChecksRule(&RequiredStatusChecksRuleParameters{
DoNotEnforceOnCreate: true,
RequiredStatusChecks: []RuleRequiredStatusChecks{
{
Context: "test",
Expand Down
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载