feat!: Add support for creating GitHub App with organizations #3222
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Thank you, @wenked !
Please address the few minor comments.
@willnorris - since this involves scrape, do you have any comments or concerns regarding the breaking change in this PR?
|
We'll see what @willnorris says, but we could alternatively have a second |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3222 +/- ##
==========================================
- Coverage 97.72% 92.94% -4.78%
==========================================
Files 153 171 +18
Lines 13390 11633 -1757
==========================================
- Hits 13085 10812 -2273
- Misses 215 727 +512
- Partials 90 94 +4 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Fixes: #3210.
BREAKING CHANGE: The
CreateAppfunction now requires two arguments:AppManifestandorgName, to support creating apps with organizations.The issue occurred because the create app URL path was only set up for creating personal GitHub apps.
My solution was to add an additional argument to the function to provide the necessary information for creating organizational GitHub Apps. The second argument,
AppConfig, now includes configuration structs with anOwnerTypethat can be either personal or organizational, and you can provide the organization name by passingOrgNamein theAppConfigstruct.For more details, see the issue: #3210.