Add support for App Callback URLs #3204
Conversation
scrape/apps.go
Outdated
| //Required. The homepage of your GitHub App. | ||
| URL *string `json:"url,omitempty"` | ||
| // The full URL of the endpoint to authenticate users via the GitHub App. | ||
| CallbackURL *string `json:"url,omitempty"` |
There was a problem hiding this comment.
This change makes no sense to me, based on line 117 above it.
Note that both fields have identical JSON bindings, which means they get mapped to the same thing:
URL *string `json:"url,omitempty"`
CallbackURL *string `json:"url,omitempty"`
There was a problem hiding this comment.
You're absolutely right. I should have copied the code from my test, but didn't.
It's now fixed.
There was a problem hiding this comment.
Thank you, @Roming22 !
Could I please trouble you to add the GitHub API Docs URL as a comment to this code that shows where this is documented?
I know this is the scrape directory, but it would be nice to have a reference to it.
Thanks again!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3204 +/- ##
==========================================
- Coverage 97.72% 92.92% -4.80%
==========================================
Files 153 171 +18
Lines 13390 11582 -1808
==========================================
- Hits 13085 10763 -2322
- Misses 215 726 +511
- Partials 90 93 +3 ☔ View full report in Codecov by Sentry. |
I do not know where, or whether, it is documented. I look at the surrounding fields and made a lucky guess. |
|
Found it! |
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
|
Thanks for the support @gmlewis! Is there an ETA for the next release? |
|
It looks like it is about time. I'll work on it. |
|
This is now available here: https://github.com/google/go-github/releases/tag/v63.0.0 |
Fixes: #3203