+
Skip to content

Conversation

lrstanley
Copy link
Contributor

Adds missing field values_editable_by for custom properties, as well as mirrors the field documentation directly from the API documentation for the other fields of custom properties.

Ref: https://docs.github.com/en/rest/orgs/custom-properties?apiVersion=2022-11-28#create-or-update-custom-properties-for-an-organization

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (2b8c7fa) to head (2480461).
Report is 57 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3164      +/-   ##
==========================================
- Coverage   97.72%   92.91%   -4.81%     
==========================================
  Files         153      171      +18     
  Lines       13390    11502    -1888     
==========================================
- Hits        13085    10687    -2398     
- Misses        215      724     +509     
- Partials       90       91       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis gmlewis changed the title feat: add missing values_editable_by field for organization custom properties feat: Add missing values_editable_by field for organization custom properties May 11, 2024
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lrstanley !
LGTM.
Merging.

@gmlewis gmlewis merged commit 51bedeb into google:master May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载