Add audit log rate limit category and make rate limit category getter public #3088
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3088 +/- ##
==========================================
- Coverage 97.72% 92.87% -4.86%
==========================================
Files 153 170 +17
Lines 13390 11404 -1986
==========================================
- Hits 13085 10591 -2494
- Misses 215 723 +508
Partials 90 90 ☔ View full report in Codecov by Sentry. |
|
@gmlewis could you take a look at this when you have some time? 🙏 (I'm notifying you as you seem to review the recent PRs, sorry if you are not the correct person for that). |
Hi @Letiste - I apologize for not seeing this two weeks ago. I'm not sure how I missed it. 😞 Don't worry about the codecov - it has lately been really flakey. I'll take a look at the PR. |
|
Thank you, @rpelliard ! |
When calling
https://api.github.com/rate_limit, the endpoint returns aaudit_lograte limit category as well. This is used for/audit-logendpoints:This PR adds this new rate limit category.
I have a use case where I need to know the rate limit category before making the request so as to not reimplement what's already done in
go-github, I made this logic public. Other users could also benefit of this change.If you think it's not reasonable and it should be kept private, I will revert this change.