+
Skip to content

Conversation

noamd-legit
Copy link
Contributor

No description provided.

@google-cla
Copy link

google-cla bot commented Nov 16, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewis gmlewis changed the title Consume the 'require_last_push_approval' field from the API response Add the 'require_last_push_approval' field Nov 16, 2022
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @noamd-legit !
Could you please also add this field (but as a *bool) to the PullRequestReviewsEnforcementUpdate struct?

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #2567 (8cc248d) into master (cbfb001) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2567   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files         125      125           
  Lines       10875    10875           
=======================================
  Hits        10656    10656           
  Misses        150      150           
  Partials       69       69           
Impacted Files Coverage Δ
github/repos.go 98.67% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@noamd-legit noamd-legit requested a review from gmlewis November 16, 2022 15:03
@noamd-legit
Copy link
Contributor Author

@gmlewis Added :)

Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@noamd-legit noamd-legit requested a review from gmlewis November 16, 2022 15:51
@gmlewis
Copy link
Collaborator

gmlewis commented Nov 16, 2022

You will probably also need to run go generate ./... as described in CONTRIBUTING.md. Sorry for the short reviews... I'm on Android.

@noamd-legit
Copy link
Contributor Author

go generate doesn't seem to generate diff after syncing with the main branch

@gmlewis
Copy link
Collaborator

gmlewis commented Nov 17, 2022

Did you literally type go generate ./... in the top-level directory?
(Not go generate.)

@noamd-legit
Copy link
Contributor Author

Yeah, but apparently I ran the command on a different branch locally 😐
Updated. Sorry for the trouble

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @noamd-legit !
LGTM.
Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载