-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add support for security manager endpoints #2530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
// Copyright 2022 The go-github AUTHORS. All rights reserved. | ||
// | ||
// Use of this source code is governed by a BSD-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package github | ||
|
||
import ( | ||
"context" | ||
"fmt" | ||
) | ||
|
||
// ListSecurityManagerTeams lists all security manager teams for an organization. | ||
// | ||
// GitHub API docs: https://docs.github.com/en/rest/orgs/security-managers#list-security-manager-teams | ||
func (s *OrganizationsService) ListSecurityManagerTeams(ctx context.Context, org string) ([]*Team, *Response, error) { | ||
u := fmt.Sprintf("orgs/%v/security-managers", org) | ||
|
||
req, err := s.client.NewRequest("GET", u, nil) | ||
if err != nil { | ||
return nil, nil, err | ||
} | ||
|
||
var teams []*Team | ||
resp, err := s.client.Do(ctx, req, &teams) | ||
if err != nil { | ||
return nil, resp, err | ||
} | ||
|
||
return teams, resp, nil | ||
} | ||
|
||
// AddSecurityManagerTeam adds a team to the list of security managers for an organization. | ||
// | ||
// GitHub API docs: https://docs.github.com/en/rest/orgs/security-managers#add-a-security-manager-team | ||
func (s *OrganizationsService) AddSecurityManagerTeam(ctx context.Context, org, team string) (*Response, error) { | ||
u := fmt.Sprintf("orgs/%v/security-managers/teams/%v", org, team) | ||
req, err := s.client.NewRequest("PUT", u, nil) | ||
if err != nil { | ||
return nil, err | ||
} | ||
|
||
return s.client.Do(ctx, req, nil) | ||
} | ||
|
||
// RemoveSecurityManagerTeam removes a team from the list of security managers for an organization. | ||
// | ||
// GitHub API docs: https://docs.github.com/en/rest/orgs/security-managers#remove-a-security-manager-team | ||
func (s *OrganizationsService) RemoveSecurityManagerTeam(ctx context.Context, org, team string) (*Response, error) { | ||
u := fmt.Sprintf("orgs/%v/security-managers/teams/%v", org, team) | ||
req, err := s.client.NewRequest("DELETE", u, nil) | ||
if err != nil { | ||
return nil, err | ||
} | ||
|
||
return s.client.Do(ctx, req, nil) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,145 @@ | ||
// Copyright 2022 The go-github AUTHORS. All rights reserved. | ||
// | ||
// Use of this source code is governed by a BSD-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package github | ||
|
||
import ( | ||
"context" | ||
"fmt" | ||
"net/http" | ||
"testing" | ||
|
||
"github.com/google/go-cmp/cmp" | ||
) | ||
|
||
func TestOrganizationsService_ListSecurityManagerTeams(t *testing.T) { | ||
client, mux, _, teardown := setup() | ||
defer teardown() | ||
|
||
mux.HandleFunc("/orgs/o/security-managers", func(w http.ResponseWriter, r *http.Request) { | ||
testMethod(t, r, "GET") | ||
fmt.Fprint(w, `[{"id":1}]`) | ||
}) | ||
|
||
ctx := context.Background() | ||
teams, _, err := client.Organizations.ListSecurityManagerTeams(ctx, "o") | ||
if err != nil { | ||
t.Errorf("Organizations.ListSecurityManagerTeams returned error: %v", err) | ||
} | ||
|
||
want := []*Team{{ID: Int64(1)}} | ||
if !cmp.Equal(teams, want) { | ||
t.Errorf("Organizations.ListSecurityManagerTeams returned %+v, want %+v", teams, want) | ||
} | ||
|
||
const methodName = "ListSecurityManagerTeams" | ||
testBadOptions(t, methodName, func() (err error) { | ||
_, _, err = client.Organizations.ListSecurityManagerTeams(ctx, "\n") | ||
return err | ||
}) | ||
|
||
testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) { | ||
got, resp, err := client.Organizations.ListSecurityManagerTeams(ctx, "o") | ||
if got != nil { | ||
t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got) | ||
} | ||
return resp, err | ||
}) | ||
} | ||
|
||
func TestOrganizationsService_ListSecurityManagerTeams_invalidOrg(t *testing.T) { | ||
client, _, _, teardown := setup() | ||
defer teardown() | ||
|
||
ctx := context.Background() | ||
_, _, err := client.Organizations.ListSecurityManagerTeams(ctx, "%") | ||
testURLParseError(t, err) | ||
} | ||
|
||
func TestOrganizationsService_AddSecurityManagerTeam(t *testing.T) { | ||
client, mux, _, teardown := setup() | ||
defer teardown() | ||
|
||
mux.HandleFunc("/orgs/o/security-managers/teams/t", func(w http.ResponseWriter, r *http.Request) { | ||
testMethod(t, r, "PUT") | ||
}) | ||
|
||
ctx := context.Background() | ||
_, err := client.Organizations.AddSecurityManagerTeam(ctx, "o", "t") | ||
if err != nil { | ||
t.Errorf("Organizations.AddSecurityManagerTeam returned error: %v", err) | ||
} | ||
|
||
const methodName = "AddSecurityManagerTeam" | ||
testBadOptions(t, methodName, func() (err error) { | ||
_, err = client.Organizations.AddSecurityManagerTeam(ctx, "\n", "\n") | ||
return err | ||
}) | ||
|
||
testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) { | ||
return client.Organizations.AddSecurityManagerTeam(ctx, "o", "t") | ||
}) | ||
} | ||
|
||
func TestOrganizationsService_AddSecurityManagerTeam_invalidOrg(t *testing.T) { | ||
client, _, _, teardown := setup() | ||
defer teardown() | ||
|
||
ctx := context.Background() | ||
_, err := client.Organizations.AddSecurityManagerTeam(ctx, "%", "t") | ||
testURLParseError(t, err) | ||
} | ||
|
||
func TestOrganizationsService_AddSecurityManagerTeam_invalidTeam(t *testing.T) { | ||
client, _, _, teardown := setup() | ||
defer teardown() | ||
|
||
ctx := context.Background() | ||
_, err := client.Organizations.AddSecurityManagerTeam(ctx, "%", "t") | ||
testURLParseError(t, err) | ||
} | ||
|
||
func TestOrganizationsService_RemoveSecurityManagerTeam(t *testing.T) { | ||
client, mux, _, teardown := setup() | ||
defer teardown() | ||
|
||
mux.HandleFunc("/orgs/o/security-managers/teams/t", func(w http.ResponseWriter, r *http.Request) { | ||
testMethod(t, r, "DELETE") | ||
}) | ||
|
||
ctx := context.Background() | ||
_, err := client.Organizations.RemoveSecurityManagerTeam(ctx, "o", "t") | ||
if err != nil { | ||
t.Errorf("Organizations.RemoveSecurityManagerTeam returned error: %v", err) | ||
} | ||
|
||
const methodName = "RemoveSecurityManagerTeam" | ||
testBadOptions(t, methodName, func() (err error) { | ||
_, err = client.Organizations.RemoveSecurityManagerTeam(ctx, "\n", "\n") | ||
return err | ||
}) | ||
|
||
testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) { | ||
return client.Organizations.RemoveSecurityManagerTeam(ctx, "o", "t") | ||
}) | ||
} | ||
|
||
func TestOrganizationsService_RemoveSecurityManagerTeam_invalidOrg(t *testing.T) { | ||
client, _, _, teardown := setup() | ||
defer teardown() | ||
|
||
ctx := context.Background() | ||
_, err := client.Organizations.RemoveSecurityManagerTeam(ctx, "%", "t") | ||
testURLParseError(t, err) | ||
} | ||
|
||
func TestOrganizationsService_RemoveSecurityManagerTeam_invalidTeam(t *testing.T) { | ||
client, _, _, teardown := setup() | ||
defer teardown() | ||
|
||
ctx := context.Background() | ||
_, err := client.Organizations.RemoveSecurityManagerTeam(ctx, "%", "t") | ||
testURLParseError(t, err) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.