+
Skip to content

Conversation

yuseferi
Copy link
Contributor

No description provided.

@google-cla
Copy link

google-cla bot commented Apr 11, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #2333 (43b4efe) into master (c63c9a9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2333   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files         118      118           
  Lines       10458    10458           
=======================================
  Hits        10254    10254           
  Misses        140      140           
  Partials       64       64           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c63c9a9...43b4efe. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @yuseferi .
Instead of adding a new example that is almost identical to the newrepo example but with a new flag, please just edit the other example to add your new flag.

@yuseferi
Copy link
Contributor Author

Thank you, @yuseferi . Instead of adding a new example that is almost identical to the newrepo example but with a new flag, please just edit the other example to add your new flag.

sure. just updated.

@yuseferi yuseferi requested a review from gmlewis April 11, 2022 20:58
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you just need to run gofmt on the modified file, and we should be ready to merge.

gmlewis referenced this pull request Apr 11, 2022
gofmt and govet are not handled by golangci-lint, which runs in a
separate actions workflow. No need to run them here as well.
@yuseferi
Copy link
Contributor Author

I think you just need to run gofmt on the modified file, and we should be ready to merge.

Done

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @yuseferi !
LGTM.
Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载