+
Skip to content

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Dec 5, 2021

Fixes: #2112.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Dec 5, 2021
@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #2218 (8c01a01) into master (b8b15df) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2218   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files         112      112           
  Lines       10117    10117           
=======================================
  Hits         9896     9896           
  Misses        154      154           
  Partials       67       67           
Impacted Files Coverage Δ
github/github.go 97.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8b15df...8c01a01. Read the comment docs.

@gmlewis
Copy link
Collaborator Author

gmlewis commented Dec 5, 2021

@lonre - Could you please review this PR and approve if you agree with the fix?

@gmlewis gmlewis requested a review from wesleimp December 5, 2021 17:39
@lonre
Copy link

lonre commented Dec 6, 2021

@gmlewis Thanks for your help.

I agree with the fix.

@gmlewis
Copy link
Collaborator Author

gmlewis commented Dec 6, 2021

Thank you, @lonre !
Merging.

@gmlewis gmlewis merged commit f5943db into google:master Dec 6, 2021
@gmlewis gmlewis deleted the issue-2112-pagination-since branch December 6, 2021 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

func populatePageValues can't handle API's returning 'since'

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载