+
Skip to content

Add support for External Groups #2217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 23, 2021
Merged

Add support for External Groups #2217

merged 9 commits into from
Dec 23, 2021

Conversation

kabesan
Copy link
Contributor

@kabesan kabesan commented Dec 5, 2021 •
edited by gmlewis
Loading

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Dec 5, 2021
@gmlewis gmlewis changed the title Add support External Groups Add support for External Groups Dec 5, 2021
gmlewis
gmlewis requested changes Dec 5, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kabesan !
Just a few tweaks, please, then we should be ready for a second LGTM before merging.

@gmlewis gmlewis requested a review from wesleimp December 5, 2021 17:03
@gmlewis
Copy link
Collaborator

gmlewis commented Dec 5, 2021

Also, please make sure to run unit tests before pushing (not force-pushing) your upcoming changes.
We squash and merge, so don't worry about the number of commits.
And finally, make sure to run go generate ./... and push those changes.
See our CONTRIBUTING.md file for more details.

kabesan and others added 5 commits December 6, 2021 14:54
@kabesan @gmlewis
Fix comments
cb5ad81 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@kabesan @gmlewis
Fix property types.
af776fe 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@kabesan
Fix properties.
d5f06a2
@kabesan
Add blank lines to tests.
d2191d9
@kabesan
Run go generate github.com/google/go-github/...
7bf95f8
@kabesan
Copy link
Contributor Author

kabesan commented Dec 6, 2021

@gmlewis Thank your review.
I fiexed, Please re-review.

@codecov
Copy link

codecov bot commented Dec 6, 2021 •
edited
Loading

Codecov Report

Merging #2217 (c0a7d7d) into master (b26fa8f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2217      +/-   ##
==========================================
+ Coverage   97.79%   97.82%   +0.02%     
==========================================
  Files         112      112              
  Lines       10036    10166     +130     
==========================================
+ Hits         9815     9945     +130     
  Misses        154      154              
  Partials       67       67
Impacted Files Coverage Δ
github/teams.go 98.14% <100.00%> (+0.20%) ⬆️
github/billing.go 100.00% <0.00%> (ø)
github/projects.go 96.32% <0.00%> (ø)
github/event_types.go 100.00% <0.00%> (ø)
github/repos_pages.go 97.11% <0.00%> (ø)
github/code-scanning.go 100.00% <0.00%> (ø)
github/actions_workflow_runs.go 100.00% <0.00%> (ø)
github/repos.go 98.70% <0.00%> (+0.01%) ⬆️
github/github.go 97.62% <0.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b26fa8f...c0a7d7d. Read the comment docs.

gmlewis
gmlewis requested changes Dec 6, 2021
View reviewed changes
gmlewis
gmlewis approved these changes Dec 6, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kabesan !
LGTM.

Awaiting second LGTM before merging.

(Please note that ALL other contributors to this repo are welcome to provide the second PR review/comment/approval that we need for merging and that we are not waiting for any particular reviewer unless otherwise noted.)

@kabesan
Copy link
Contributor Author

kabesan commented Dec 7, 2021

Fixed for diff coverage!

@kabesan
Copy link
Contributor Author

kabesan commented Dec 12, 2021

@gmlewis Hi
Is second reviewer not active?
Can you add other reviewers?

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 12, 2021

@gmlewis Hi Is second reviewer not active? Can you add other reviewers?

I am no longer able to add other reviewers, but any other contributor to this repo is welcome to review.

@kabesan
Copy link
Contributor Author

kabesan commented Dec 17, 2021

Hi @pierce-m
Can you review this PR?
I'm waiting for second review.

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 23, 2021

Thank you, @pierce-m !
Merging.

@gmlewis gmlewis merged commit 63a1994 into google:master Dec 23, 2021
@gmlewis gmlewis mentioned this pull request Jan 13, 2022
Merged
@bodgit bodgit mentioned this pull request Feb 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewis gmlewis gmlewis approved these changes

@wesleimp wesleimp Awaiting requested review from wesleimp

+1 more reviewer

@pierce-m pierce-m pierce-m approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support External Groups API

3 participants

@kabesan @gmlewis @pierce-m
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载