+
Skip to content

Conversation

devfd
Copy link
Contributor

@devfd devfd commented Nov 4, 2021

No description provided.

@google-cla
Copy link

google-cla bot commented Nov 4, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Nov 4, 2021
@devfd
Copy link
Contributor Author

devfd commented Nov 4, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Nov 4, 2021
@gmlewis gmlewis changed the title add missing fields to Timeline Add missing fields to Timeline Nov 5, 2021
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @devfd .
Please make sure to run go generate ./... and push (not force-push) the changes to the PR.
See CONTRIBUTING.md for more details.

@devfd
Copy link
Contributor Author

devfd commented Nov 5, 2021

my bad, thanks @gmlewis

@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #2197 (6089613) into master (0511421) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2197   +/-   ##
=======================================
  Coverage   97.79%   97.79%           
=======================================
  Files         112      112           
  Lines       10003    10003           
=======================================
  Hits         9782     9782           
  Misses        154      154           
  Partials       67       67           
Impacted Files Coverage Δ
github/issues_timeline.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0511421...6089613. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @devfd !
LGTM.
Merging.

@gmlewis gmlewis merged commit d3c6514 into google:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载