+
Skip to content

Add support for Packages API #2076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 27, 2021
Merged

Add support for Packages API #2076

merged 9 commits into from
Sep 27, 2021

Conversation

Cyb3r-Jak3
Copy link
Contributor

Adds support for Packages API through expansion of Users and Organization Services.

Would resolve #2075

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Sep 2, 2021
gmlewis
gmlewis requested changes Sep 2, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Cyb3r-Jak3 !
This is off to a great start. I have to run now, but will continue my review later.
This should give you a good idea of what I'm looking for.

@Cyb3r-Jak3 Cyb3r-Jak3 requested a review from gmlewis September 10, 2021 02:13
@gmlewis gmlewis changed the title Adds support for Packages API Add support for Packages API Sep 10, 2021
@gmlewis
Copy link
Collaborator

gmlewis commented Sep 10, 2021

Thank you, @Cyb3r-Jak3 , but I'm going to hold off on a complete review until all unit tests are passing.
It looks like they are currently failing here:

    orgs_packages_test.go:208: Request parameters: map[state:[deleted]], want map[page:[2] per_page:[10] state:[deleted]]
--- FAIL: TestOrganizationsService_ListPackagesVersions (0.00s)

Please see our CONTRIBUTING.md guide to show you how to run the tests before pushing changes. Thanks.

@Cyb3r-Jak3
Copy link
Contributor Author

@gmlewis, sorry about that. All good now.

@codecov
Copy link

codecov bot commented Sep 10, 2021 •
edited
Loading

Codecov Report

Merging #2076 (c0223f6) into master (ee49f8e) will decrease coverage by 0.00%.
The diff coverage is 97.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2076      +/-   ##
==========================================
- Coverage   97.77%   97.77%   -0.01%     
==========================================
  Files         109      111       +2     
  Lines        9720     9932     +212     
==========================================
+ Hits         9504     9711     +207     
- Misses        150      154       +4     
- Partials       66       67       +1
Impacted Files Coverage Δ
github/packages.go 85.71% <50.00%> (-14.29%) ⬇️
github/orgs_packages.go 96.42% <96.42%> (ø)
github/users_packages.go 100.00% <100.00%> (ø)
github/actions_runner_groups.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee49f8e...c0223f6. Read the comment docs.

gmlewis
gmlewis requested changes Sep 10, 2021
View reviewed changes
@Cyb3r-Jak3 Cyb3r-Jak3 requested a review from gmlewis September 10, 2021 22:28
gmlewis
gmlewis reviewed Sep 11, 2021
View reviewed changes
gmlewis
gmlewis reviewed Sep 11, 2021
View reviewed changes
@gmlewis
Update github/orgs_packages_test.go
e3a776f 
I'll commit this one... can you please address the other ones to match the testing pattern?
gmlewis
gmlewis requested changes Sep 11, 2021
View reviewed changes
@Cyb3r-Jak3 Cyb3r-Jak3 requested a review from gmlewis September 11, 2021 00:27
gmlewis
gmlewis approved these changes Sep 11, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Cyb3r-Jak3 !
This looks great! I really appreciate your patience with me and my reviews.
LGTM.

Awaiting second LGTM before merging.

@gmlewis gmlewis requested a review from wesleimp September 11, 2021 00:58
@Cyb3r-Jak3
Copy link
Contributor Author

@wesleimp Nudge

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 27, 2021

@Parker77 - if you have time to do a code review, that would be greatly appreciated.

Parker77
Parker77 approved these changes Sep 27, 2021
View reviewed changes
Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 27, 2021

LGTM.

Thank you, @Parker77 !
Merging.

@gmlewis gmlewis merged commit f07b9cb into google:master Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewis gmlewis gmlewis approved these changes

@wesleimp wesleimp Awaiting requested review from wesleimp

+1 more reviewer

@Parker77 Parker77 Parker77 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Does not to be any support for the Packages API

3 participants

@Cyb3r-Jak3 @gmlewis @Parker77
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载