+
Skip to content

Conversation

Richard-de-Vries
Copy link
Contributor

#2073 Add auto merge support

Pr to add the allow_auto_merge property that is newly exposed in the github api

Changed enities

Tests

I could not find what tests should be changed when adding a new property so i did not add any. If this pr should include tests please point me to the files i should be looking at ?

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Sep 1, 2021
@gmlewis
Copy link
Collaborator

gmlewis commented Sep 1, 2021

Hi @Richard-de-Vries, did you remember to run go generate ./... as discussed in our CONTRIBUTING.md file?

@Richard-de-Vries
Copy link
Contributor Author

Hello @gmlewis I'm fairly new to go 😅.
If i run the go generate ./.. command, while in the base of the git repository, it does not seem to do anything.
I would love any help you are able to give, and would love to learn 😄

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #2074 (8c497d9) into master (378e484) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2074   +/-   ##
=======================================
  Coverage   97.75%   97.75%           
=======================================
  Files         107      107           
  Lines        9600     9601    +1     
=======================================
+ Hits         9384     9385    +1     
  Misses        150      150           
  Partials       66       66           
Impacted Files Coverage Δ
github/repos.go 98.64% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 378e484...8c497d9. Read the comment docs.

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 1, 2021

Hello @gmlewis I'm fairly new to go .
If i run the go generate ./.. command, while in the base of the git repository, it does not seem to do anything.
I would love any help you are able to give, and would love to learn

Welcome to Go, @Richard-de-Vries !
It actually looks like you already got it to work. 😂

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Richard-de-Vries !
LGTM.
Merging.

@gmlewis gmlewis merged commit 88b13f9 into google:master Sep 1, 2021
@Richard-de-Vries Richard-de-Vries deleted the 2073-introduce-auto-merge-option-on-repo branch September 2, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载