-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Set up workflow for golangci #2020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a10f81d
Create linter.yml
mmorel-35 bc0d175
Create .golangci.yml
mmorel-35 3310cc2
Update linter.yml
mmorel-35 360f225
Update linter.yml
mmorel-35 2d6f191
Update .github/workflows/linter.yml
mmorel-35 6cc057d
remove --issues-exit-code=0
mmorel-35 017b24b
Update .golangci.yml
mmorel-35 6c12fad
Update activity_notifications.go
mmorel-35 b003a5c
Update .golangci.yml
mmorel-35 4bcc57b
Update .golangci.yml
mmorel-35 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
on: [push, pull_request] | ||
name: linter | ||
|
||
jobs: | ||
lint: | ||
strategy: | ||
matrix: | ||
go-version: [1.x] | ||
platform: [ubuntu-latest] | ||
runs-on: ${{ matrix.platform }} | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
|
||
- name: golangci-lint | ||
uses: golangci/golangci-lint-action@5c56cd6c9dc07901af25baab6f2b0d9f3b7c3018 #v2.5.2 | ||
with: | ||
version: v1.41 | ||
args: --verbose |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
linters: | ||
# TODO: fix errors so that all of the linters below pass. | ||
# The linters that are commented out, as well as those explicitly disabled, | ||
# are currently failing. We should fix those failures or define exclusion | ||
# rules, and then enable those linters. | ||
enable: | ||
- dogsled | ||
- dupl | ||
- gofmt | ||
- goimports | ||
# - gosec | ||
- misspell | ||
- nakedret | ||
# - stylecheck | ||
# - unconvert | ||
# - unparam | ||
# - whitespace | ||
disable: | ||
- errcheck | ||
- gosimple | ||
- staticcheck | ||
- ineffassign | ||
- unused | ||
issues: | ||
exclude-rules: | ||
- linters: | ||
- dogsled | ||
text: "declaration has 3 blank identifiers" | ||
path: _test\.go | ||
- linters: | ||
- dupl | ||
path: _test\.go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest to add ercheck and govet to the list
https://golangci-lint.run/usage/linters/
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those two are active by default, see https://golangci-lint.run/usage/linters/#enabled-by-default-linters. I haven't deactivated them. It would require
disable-all
to be true under the linters item in this casehttps://golangci-lint.run/usage/configuration/#config-file