-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Set up Dependabot for gomod and github-actions dependencies #2019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What is this for and why are you submitting this PR? |
Hi! I saw it defined in https://github.com/google/go-querystring, I thought the project might be interested |
@willnorris - I defer to your judgment on this one and #2020. |
Codecov Report
@@ Coverage Diff @@
## master #2019 +/- ##
=======================================
Coverage 97.87% 97.87%
=======================================
Files 107 107
Lines 6907 6907
=======================================
Hits 6760 6760
Misses 81 81
Partials 66 66 Continue to review full report at Codecov.
|
Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Hey @mmorel-35, thanks or these changes. Just to help keep PRs a bit more focused on specific things, could we keep this one limited to the dependabot changes, and make those other testing changes in a separate PR with clearer messages on what they're doing and why? |
And honestly, I'd love to just check-in the dependabot config without the go.mod changes, since that will also let us test that dependabot bumps those dependencies itself. |
Alright, I'm closing this pr and will open dedicated prs |
oh, I didn't mean to close this one necessarily. We still need the original commit to update the dependabot config. I just meant reverting the other unrelated commits in this PR. Then, we I do a squash merge, it'll reduce it back to just the dependabot change. |
Don't worry, it's in #2047, now |
And #2054, for the cache part |
No description provided.