+
Skip to content

Conversation

mmorel-35
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jul 21, 2021
@gmlewis
Copy link
Collaborator

gmlewis commented Jul 21, 2021

What is this for and why are you submitting this PR?

@gmlewis gmlewis added the DO NOT MERGE Do not merge this PR. label Jul 21, 2021
@mmorel-35
Copy link
Contributor Author

Hi! I saw it defined in https://github.com/google/go-querystring, I thought the project might be interested

@gmlewis
Copy link
Collaborator

gmlewis commented Jul 22, 2021

@willnorris - I defer to your judgment on this one and #2020.

@gmlewis gmlewis removed the DO NOT MERGE Do not merge this PR. label Jul 22, 2021
@gmlewis gmlewis requested a review from willnorris July 22, 2021 16:11
@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #2019 (77086e6) into master (8bd2892) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2019   +/-   ##
=======================================
  Coverage   97.87%   97.87%           
=======================================
  Files         107      107           
  Lines        6907     6907           
=======================================
  Hits         6760     6760           
  Misses         81       81           
  Partials       66       66           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd2892...77086e6. Read the comment docs.

dependabot bot and others added 2 commits August 19, 2021 09:39
Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@willnorris
Copy link
Collaborator

Hey @mmorel-35, thanks or these changes. Just to help keep PRs a bit more focused on specific things, could we keep this one limited to the dependabot changes, and make those other testing changes in a separate PR with clearer messages on what they're doing and why?

@willnorris
Copy link
Collaborator

And honestly, I'd love to just check-in the dependabot config without the go.mod changes, since that will also let us test that dependabot bumps those dependencies itself.

@mmorel-35
Copy link
Contributor Author

Alright, I'm closing this pr and will open dedicated prs

@mmorel-35 mmorel-35 closed this Aug 19, 2021
@mmorel-35 mmorel-35 deleted the chore/dependabot branch August 19, 2021 16:25
@willnorris
Copy link
Collaborator

oh, I didn't mean to close this one necessarily. We still need the original commit to update the dependabot config. I just meant reverting the other unrelated commits in this PR. Then, we I do a squash merge, it'll reduce it back to just the dependabot change.

@mmorel-35
Copy link
Contributor Author

Don't worry, it's in #2047, now

@mmorel-35
Copy link
Contributor Author

And #2054, for the cache part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载