+
Skip to content

feat: support new release discussions feature #1856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2021
Merged

feat: support new release discussions feature #1856

merged 2 commits into from
Apr 21, 2021

Conversation

caarlos0
Copy link
Contributor

@caarlos0 caarlos0 commented Apr 21, 2021

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Apr 21, 2021
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #1856 (465a96b) into master (94d2fbb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1856   +/-   ##
=======================================
  Coverage   97.64%   97.64%           
=======================================
  Files         105      105           
  Lines        6762     6764    +2     
=======================================
+ Hits         6603     6605    +2     
  Misses         86       86           
  Partials       73       73           
Impacted Files Coverage Δ
github/repos_releases.go 89.37% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94d2fbb...465a96b. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @caarlos0 !
LGTM.
Merging.

@gmlewis gmlewis merged commit b235769 into google:master Apr 21, 2021
@caarlos0 caarlos0 deleted the release-discussions branch April 21, 2021 13:54
This was referenced May 21, 2021
This was referenced Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载