-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Update hook_id to int64 #1837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hook_id to int64 #1837
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
The hook_id field is not a string it represented as a number, updated the HookID to int64. Signed-off-by: Brett Logan <lindluni@github.com>
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #1837 +/- ##
=======================================
Coverage 97.56% 97.56%
=======================================
Files 104 104
Lines 6602 6602
=======================================
Hits 6441 6441
Misses 87 87
Partials 74 74
Continue to review full report at Codecov.
|
Working on the CLA |
Pagination is also broken for the audit-log API, I've opened an issue internally as the current Pagination mechanism for this endpoint is completely different from all other endpoints. So while this change is good, it wont fix the actual audit log API. I'll open an issue here to track that problem as well. |
Thank you, @lindluni ! |
I'm happy to have you submit a separate PR. I'm just waiting on a response from legal. Appreciate the help. I'll get an issue open here for the pagination problem as well to track it externally, once I get an update from the engineering team I'll update it here as well. |
The hook_id field of the Audit Log API is not a string. It is represented as a number, updated the HookID to int64 to match other fields of type number.
Signed-off-by: Brett Logan lindluni@github.com