-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix invalid response and rename ListPlanAccountsForAccount (fixes #1270) #1827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Codecov Report
@@ Coverage Diff @@
## master #1827 +/- ##
==========================================
+ Coverage 97.56% 97.59% +0.02%
==========================================
Files 104 104
Lines 6602 6599 -3
==========================================
- Hits 6441 6440 -1
+ Misses 87 86 -1
+ Partials 74 73 -1
Continue to review full report at Codecov.
|
Yes, those seem like reasonable changes (since we are already breaking the API). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @sethaustinx !
LGTM.
Awaiting second LGTM before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💙
Thank you, @wesleimp ! |
Awesome 🧡 |
To simplify review and address specific requests from #1270 (comment) I've made separate commits.
Also wording doesn't seem to match GitHub docs anymore.
If that's ok @gmlewis, I'd like to rename:
What do you think?