+
Skip to content

Add Workflow Dispatch Event by ID and FileName #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 2, 2020
Merged

Add Workflow Dispatch Event by ID and FileName #1640

merged 3 commits into from
Dec 2, 2020

Conversation

n1lesh
Copy link
Contributor

@n1lesh n1lesh commented Oct 12, 2020 •
edited
Loading

Fixes #1639

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Oct 12, 2020
@codecov
Copy link

codecov bot commented Oct 12, 2020 •
edited
Loading

Codecov Report

Merging #1640 (8288be4) into master (a64f3a6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1640      +/-   ##
==========================================
+ Coverage   69.98%   70.00%   +0.01%     
==========================================
  Files          98       98              
  Lines        6374     6377       +3     
==========================================
+ Hits         4461     4464       +3     
  Misses        991      991              
  Partials      922      922
Impacted Files Coverage Δ
github/actions_workflows.go 70.00% <100.00%> (+1.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a64f3a6...8288be4. Read the comment docs.

gmlewis
gmlewis requested changes Oct 12, 2020
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @n1lesh !

One question and one comment, please.

gmlewis
gmlewis approved these changes Oct 12, 2020
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @n1lesh !
LGTM.

Awaiting second LGTM before merging.

@gmlewis gmlewis requested a review from wesleimp October 12, 2020 22:21
@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Oct 12, 2020
@gmlewis
Copy link
Collaborator

gmlewis commented Dec 2, 2020

@erikkn - it would be nice to get all breaking changes into the next major release (v33.0.0) so that we don't have to bump the major version more often than necessary. If you feel like reviewing this PR, that would be greatly appreciated.

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 2, 2020

friendly ping @wesleimp

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 2, 2020

@nightlark - if you are available for a review, it would be greatly appreciated.

erikkn
erikkn approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@erikkn erikkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 2, 2020

Thank you, @erikkn !
Merging.

@gmlewis gmlewis merged commit 98b466b into google:master Dec 2, 2020
@n1lesh n1lesh deleted the workflow-dispatch-event branch September 29, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

@erikkn erikkn erikkn approved these changes

@wesleimp wesleimp Awaiting requested review from wesleimp

Assignees
No one assigned
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't create workflow dispatch event by filename
3 participants
@n1lesh @gmlewis @erikkn
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载