Remove graduated GitHub v3 API preview header #1636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1636 +/- ##
==========================================
- Coverage 67.95% 67.87% -0.09%
==========================================
Files 97 97
Lines 8824 8802 -22
==========================================
- Hits 5996 5974 -22
Misses 1912 1912
Partials 916 916
Continue to review full report at Codecov.
|
gmlewis
requested changes
Oct 2, 2020
There was a problem hiding this comment.
Thank you, @n1lesh , but this is the wrong approach.
We need to literally remove it, not replace it.
Please see https://github.com/google/go-github/pull/1618/files as a recent example of how this is done.
|
Thank you, @nightlark ! |
brackendawson
added a commit
to brackendawson/go-github
that referenced
this pull request
Feb 22, 2022
This reverts commit 76c3c3d.
gmlewis
pushed a commit
that referenced
this pull request
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed Accept header (with value mediaTypeCheckRunsPreview). Since checks run is out of preview, didn't see any value in keeping it.
Followed as per,
Graduation of preview: https://developer.github.com/changes/2020-10-01-graduate-antiope-preview/
Docs: https://docs.github.com/en/free-pro-team@latest/rest/reference/checks