Fix receivers and other breaking changes #1487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1487 +/- ##
==========================================
- Coverage 68.13% 68.12% -0.02%
==========================================
Files 94 94
Lines 8467 8454 -13
==========================================
- Hits 5769 5759 -10
+ Misses 1831 1829 -2
+ Partials 867 866 -1
Continue to review full report at Codecov.
|
gmlewis
added a commit
to gmlewis/go-github
that referenced
this pull request
Apr 9, 2020
|
This is now the PR that would ideally be included before we bump the major version to Awaiting LGTM before merging. |
|
Thank you, @wesleimp ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1477 found a number of problems in the repo that would cause breaking API changes to fix them.
Instead of including them there, it was decided to pull the breaking API changes into a separate PR, which is this one.