+
Skip to content

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Jan 9, 2020

This is the second attempt to bump the major version to v29 after #1344 failed.
Release v29.0.0 was broken so this will be released as v29.0.1.

@gmlewis gmlewis requested a review from dmitshur January 9, 2020 00:03
@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jan 9, 2020
@gmlewis
Copy link
Collaborator Author

gmlewis commented Jan 9, 2020

@dmitshur - if you could please check this when you get a chance, I would greatly appreciate it!
I will release this as v29.0.1 if there are no objections.

@gmlewis
Copy link
Collaborator Author

gmlewis commented Jan 9, 2020

Fixes #1365.

Copy link
Member

@dmitshur dmitshur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested this change and don't see any issues.

@gmlewis
Copy link
Collaborator Author

gmlewis commented Jan 9, 2020

Thank you, @dmitshur!
Merging.

@gmlewis gmlewis merged commit a3f3689 into google:master Jan 9, 2020
@gmlewis gmlewis deleted the v29 branch January 9, 2020 00:19
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载