+
Skip to content

Add repository creation permissions field #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

davidji99
Copy link
Contributor

@davidji99 davidji99 commented Jul 1, 2019

Resolves davidji99#3

This PR is to introduce the application/vnd.github.surtur-preview+json Accept header when getting information about an organization.

Reference: https://developer.github.com/v3/orgs/#get-an-organization

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jul 1, 2019
@davidji99 davidji99 marked this pull request as ready for review July 1, 2019 05:09
@davidji99 davidji99 force-pushed the issues/3-add-repository-creation-permissi branch from 3d41f07 to b7aed5b Compare July 1, 2019 05:11
@davidji99 davidji99 force-pushed the issues/3-add-repository-creation-permissi branch from b7aed5b to 59005a5 Compare July 1, 2019 06:16
@codecov
Copy link

codecov bot commented Jul 1, 2019

Codecov Report

Merging #1213 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1213      +/-   ##
==========================================
+ Coverage   73.32%   73.32%   +<.01%     
==========================================
  Files          84       84              
  Lines        5987     5988       +1     
==========================================
+ Hits         4390     4391       +1     
  Misses        832      832              
  Partials      765      765
Impacted Files Coverage Δ
github/github.go 89.31% <ø> (ø) ⬆️
github/orgs.go 71.87% <100%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60c47f3...d5b17a0. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @davidji99!
Just a few minor changes please, and then we should be good to merge after we get a second LGTM.

@gmlewis gmlewis requested a review from gauntface July 1, 2019 11:36
@davidji99 davidji99 force-pushed the issues/3-add-repository-creation-permissi branch from 6c64bdb to 7736075 Compare July 2, 2019 02:00
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @davidji99!
LGTM.

Awaiting second LGTM before merging.

@gmlewis
Copy link
Collaborator

gmlewis commented Jul 8, 2019

Thank you, @gauntface!
Merging.

@gmlewis gmlewis merged commit 1bab17e into google:master Jul 8, 2019
@davidji99 davidji99 deleted the issues/3-add-repository-creation-permissi branch July 9, 2019 04:21
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add repository creation permissions field
4 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载