+
Skip to content

Add missing LdapDn field in Users class #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 25, 2019
Merged

Conversation

anjanashenoy
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@anjanashenoy
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Jun 25, 2019
@gmlewis
Copy link
Collaborator

gmlewis commented Jun 25, 2019

Did you run your code through gofmt?

@gmlewis
Copy link
Collaborator

gmlewis commented Jun 25, 2019

https://golang.org/cmd/gofmt/
gofmt -w filename.go

@gmlewis
Copy link
Collaborator

gmlewis commented Jun 25, 2019

You don't need to edit the two auto-generated files... please see the go generate ./... section of CONTRIBUTING.md.

@anjanashenoy
Copy link
Contributor Author

You don't need to edit the two auto-generated files... please see the go generate ./... section of CONTRIBUTING.md.

oh okay, my bad. i think i fixed the issue

@gmlewis
Copy link
Collaborator

gmlewis commented Jun 25, 2019

LGTM. Merging.

@gmlewis gmlewis merged commit ababee0 into google:master Jun 25, 2019
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载