Add Support to preview endpoints to list branches or pull requests fo… #1186

sks444 · 2019-06-08T14:00:29Z

…r a commit

codecov · 2019-06-08T14:43:54Z

Codecov Report

Merging #1186 into master will decrease coverage by 0.03%.
The diff coverage is 61.53%.

@@            Coverage Diff            @@
##           master   #1186      +/-   ##
=========================================
- Coverage   70.24%   70.2%   -0.04%     
=========================================
  Files          84      84              
  Lines        5878    5904      +26     
=========================================
+ Hits         4129    4145      +16     
- Misses        958     963       +5     
- Partials      791     796       +5

Impacted Files	Coverage Δ
github/github.go	`87.53% <ø> (ø)`	⬆️
github/pulls.go	`71.42% <60%> (-1.24%)`	⬇️
github/repos_commits.go	`70.73% <63.63%> (-1.1%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a35880...bc8872c. Read the comment docs.

gmlewis

Looks great, @sks444 !

Just a couple minor tweaks, please, and then we can merge once we get a second LGTM.

gmlewis · 2019-06-08T17:55:00Z

github/repos_commits.go

@@ -115,6 +115,13 @@ type CommitsListOptions struct {
 	ListOptions
 }

+// BranchCommit is the result of listing branches with commit sha.


Let's please change this to SHA instead of sha.
(Also, please don't use force commits just to make things easier for reviewers.)

gmlewis · 2019-06-08T17:56:22Z

github/repos_commits.go

+// ListBranchesHeadCommit gets all branches where the given commit SHA is the HEAD,
+// or latest commit for the branch.
+//
+// Github API docs: https://developer.github.com/v3/repos/commits/#list-branches-for-head-commit


Please capitalize the H in GitHub.

sks444 · 2019-06-09T09:37:50Z

Thanks for the review @gmlewis, I have updated the PR.

gmlewis

Thank you, @sks444!

Awaiting second LGTM before merging.

vaibhavsingh97 · 2019-06-10T12:00:17Z

github/repos_commits_test.go

+	client, mux, _, teardown := setup()
+	defer teardown()
+
+	// given


Please don't add incomplete comment, can you please remove it?

vaibhavsingh97 · 2019-06-10T12:01:59Z

github/pulls.go

@@ -149,7 +149,35 @@ func (s *PullRequestsService) List(ctx context.Context, owner string, repo strin
 	// TODO: remove custom Accept header when this API fully launches.
 	acceptHeaders := []string{mediaTypeLabelDescriptionSearchPreview, mediaTypeLockReasonPreview, mediaTypeDraftPreview}
 	req.Header.Set("Accept", strings.Join(acceptHeaders, ", "))
+	var pulls []*PullRequest


Please don't edit code which is not related to the issue 😄

vaibhavsingh97

LGTM, just a minor change needed.
Good work @sks444 ! 🎉

googlebot · 2019-06-10T18:30:56Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

sks444 · 2019-06-10T18:44:14Z

Thanks @vaibhavsingh97, I have updated the pr according to your review.

@gmlewis, There was some conflicts so I did the rebase and did the push without using --force and this happened. Should I squash my commits into a single commit and do a force push or it is okay?

gmlewis · 2019-06-10T18:53:35Z

@sks444 - sure, go ahead and do a force push since all the review feedback has already been addressed. That should hopefully clear it up.

…r a commit

googlebot · 2019-06-10T19:06:34Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

sks444 · 2019-06-10T19:08:15Z

Thanks @gmlewis, it's done.

gmlewis · 2019-06-10T20:16:53Z

Thank you, @sks444!
And thank you for the review, @vaibhavsingh97!

Merging.

Fixes google#1151.

googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jun 8, 2019

sks444 force-pushed the list-branches-or-pull-requests-for-a-commit branch 2 times, most recently from a057467 to cd62ca4 Compare June 8, 2019 14:39

gmlewis requested changes Jun 8, 2019

View reviewed changes

gmlewis requested a review from gauntface June 8, 2019 17:58

gmlewis approved these changes Jun 9, 2019

View reviewed changes

vaibhavsingh97 reviewed Jun 10, 2019

View reviewed changes

googlebot added cla: no and removed cla: yes Indication that the PR author has signed a Google Contributor License Agreement. labels Jun 10, 2019

Add Support to preview endpoints to list branches or pull requests fo…

bc8872c

…r a commit

sks444 force-pushed the list-branches-or-pull-requests-for-a-commit branch from 1fb3a7b to bc8872c Compare June 10, 2019 19:06

googlebot added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Jun 10, 2019

gmlewis merged commit 361256a into google:master Jun 10, 2019

n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020

Add preview support to list branches or PRs for a commit (google#1186)

f94589e

Fixes google#1151.

mengmichael1 mentioned this pull request Dec 15, 2021

Update comment on ListPullRequestsWithCommit API #2228

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Support to preview endpoints to list branches or pull requests fo… #1186

Add Support to preview endpoints to list branches or pull requests fo… #1186

Uh oh!

sks444 commented Jun 8, 2019

Uh oh!

codecov bot commented Jun 8, 2019 •

edited

Loading

Uh oh!

gmlewis left a comment

Uh oh!

gmlewis Jun 8, 2019

Uh oh!

gmlewis Jun 8, 2019

Uh oh!

sks444 commented Jun 9, 2019

Uh oh!

gmlewis left a comment

Uh oh!

vaibhavsingh97 Jun 10, 2019

Uh oh!

vaibhavsingh97 Jun 10, 2019

Uh oh!

vaibhavsingh97 left a comment

Uh oh!

googlebot commented Jun 10, 2019

Uh oh!

sks444 commented Jun 10, 2019

Uh oh!

gmlewis commented Jun 10, 2019

Uh oh!

googlebot commented Jun 10, 2019

Uh oh!

sks444 commented Jun 10, 2019

Uh oh!

gmlewis commented Jun 10, 2019

Uh oh!

Uh oh!

Add Support to preview endpoints to list branches or pull requests fo… #1186

Add Support to preview endpoints to list branches or pull requests fo… #1186

Uh oh!

Conversation

sks444 commented Jun 8, 2019

Uh oh!

codecov bot commented Jun 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

gmlewis Jun 8, 2019

Choose a reason for hiding this comment

Uh oh!

gmlewis Jun 8, 2019

Choose a reason for hiding this comment

Uh oh!

sks444 commented Jun 9, 2019

Uh oh!

gmlewis left a comment

Choose a reason for hiding this comment

Uh oh!

vaibhavsingh97 Jun 10, 2019

Choose a reason for hiding this comment

Uh oh!

vaibhavsingh97 Jun 10, 2019

Choose a reason for hiding this comment

Uh oh!

vaibhavsingh97 left a comment

Choose a reason for hiding this comment

Uh oh!

googlebot commented Jun 10, 2019

Uh oh!

sks444 commented Jun 10, 2019

Uh oh!

gmlewis commented Jun 10, 2019

Uh oh!

googlebot commented Jun 10, 2019

Uh oh!

sks444 commented Jun 10, 2019

Uh oh!

gmlewis commented Jun 10, 2019

Uh oh!

Uh oh!

codecov bot commented Jun 8, 2019 •

edited

Loading