+
Skip to content

Дополнения gokalkan-а. #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 43 commits into
base: master
Choose a base branch
from
Open

Дополнения gokalkan-а. #30

wants to merge 43 commits into from

Conversation

Tr8ch
Copy link

@Tr8ch Tr8ch commented Dec 18, 2023 •
edited
Loading

Дополнили и улучшили некоторые моменты.

Проект основывается на библиотеке KalkanCrypt и не все методы были реализованы в проекте из этой библиотеки.
Так же не все методы были реализованы в gokalkan из ckalkan - a.
Мы постарались дополнить и улучшить методы.

Что было сделано:

1) Добавлены методы из библиотеки KalkanCrypt:

  • SignHash
  • KC_getCertFromXML
  • KC_getSigAlgFromXML
  • KC_GetTimeFromSig
  • ZipConVerify
  • ZipConSign
  • KC_getCertFromZipFile

2) Реализованы методы из ckalkan:

  • SignHash()
  • SignXML()
  • VerifyXML()
  • X509ExportCertificateFromStore()
  • X509CertificateGetInfo()
  • GetCertFromXML()
  • GetSigAlgFromXML()
  • GetTimeFromSig()
  • SetProxy()

3) Добавлены примеры работы методов gokalkan в gokalkan/internal/testdata/example_test.go:

  • Sign()
  • Verify()
  • GetTimeFromSig()
  • SignWSSE()
  • X509ExportCertificateFromStore()
  • X509CertificateGetInfo()
  • GetCertFromXML()
  • SignXML()
  • VerifyXML()
  • SignHash()

4) Доработки, улучшения:

  • Добавлена структура для приёма функциями Verify (VerifyInput)
  • Добавлен флаг для ckalkan.X509ValidateCert()
  • Добавлен флаг для ckalkan.X509ExportCertificateFromStore()
  • Интерфейс Kalkan перенесен в gokalkan/types/ и расширен новыми методами

Над работой трудились:

Tr8ch and others added 24 commits December 17, 2023 17:20
@Tr8ch
feat: implemented methods from libKalkanCrypt, which use zip files
3abde4d
@Tr8ch
feat: example file for documentation.
3b747b7 
Implemented examples for this methods:
- gokalkan.Sign()
- gokalkan.Verify()
- gokalkan.GetTimeFromSig()
@blsbk
ckalkan methods for XML added
edd7d7d
@Tr8ch
feat: implemented SignHash method from libKalkanCrypt
c74d300
@Tr8ch
feat: implemented GetTimeFromSig method from ckalkan
ce36564
@ymoldabe
fix: Correct X509ValidateCertificate method to accept flags
fd6b647
@ymoldabe
feat: Add types/kalkan.go
a98e95b 
fix: Correct wrapper.go
@ymoldabe
fix: Correct ValidateCert and ValidateCertOCSP methods
238709b
@ymoldabe
feat: Enhance VerifyXML method
870119e
@ymoldabe
feat: Implement SignXML and SignHash methods
1433dcc
@saboopher
feat: X509ExportCertificateFromStore method is implemented from ckalkan
2a1b3de
@saboopher
feat: X509CertificateGetInfo method is implemented from ckalkan, Cert…
0c0edac 
…PropMapmap is added
@saboopher
feat: X509ExportCertificateFromStore method is implemented from ckalkan
f4d66d1
@saboopher
feat: GetCertFromXML method is implemented from ckalkan
0d162d1
@saboopher
feat: examples for GetCertFromXML, X509CertificateGetInfo, X509Export…
9935249 
…CertificateFromStore, SignWSSE were added
@abdullayerezhep
fix: use verifyInput struct in input
baeb8e3
@abdullayerezhep
Merge branch 'feat/gokalkan-enhancement' of github.com:Tr8ch/gokalkan…
4e88272 
… into feat/gokalkan-enhancement
@ymoldabe
feat: Add examples for SignXML, VerifyXML, SignHash methods
1cd3fe5
@Tr8ch
fix: closing NewClient of gokalkan in example file
0ca5a9c
@abdullayerezhep
feat: implement SetProxy method from ckalkan
fdfe84a
@abdullayerezhep
Merge branch 'feat/gokalkan-enhancement' of github.com:Tr8ch/gokalkan…
eb76473 
… into feat/gokalkan-enhancement
@Tr8ch
fix: some comments
7783fbf
@Tr8ch
feat: implemented GetSigAlgFromXML from ckalkan in gokalkan
3706eee
@Tr8ch
feat: expanded the Kalkan interface{} with new methods
2ac60c6
atlekbai
atlekbai requested changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@atlekbai atlekbai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Оставил замечания

@Tr8ch
Copy link
Author

Tr8ch commented Dec 20, 2023

Поменял сигнатуру:

GetTimeFromSig(data string, base64 bool) (time.Time, error)

На след. сигнатуру:

GetTimeFromSig(cmsDer []byte) (time.Time, error)

@AidarSource
Copy link

Вау, круто! Как раз хотел использовать GetTimeFromSig(), буду ждать релиза

@Tr8ch Tr8ch requested a review from atlekbai July 22, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atlekbai atlekbai Awaiting requested review from atlekbai

3 more reviewers

@AidarSource AidarSource AidarSource left review comments

@ymoldabe ymoldabe ymoldabe left review comments

@saboopher saboopher saboopher left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Tr8ch @AidarSource @atlekbai @ymoldabe @saboopher @blsbk @abdullayerezhep
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载